lists - sublists

Question

why is my code wrong ?
```
musical_groups = [
    ["Ad Rock", "MCA", "Mike D."],
    ["John Lennon", "Paul McCartney", "Ringo Starr", "George Harrison"],
    ["Salt", "Peppa", "Spinderella"],
    ["Rivers Cuomo", "Patrick Wilson", "Brian Bell", "Scott Shriner"],
    ["Chuck D.", "Flavor Flav", "Professor Griff", "Khari Winn", "DJ Lord"],
    ["Axl Rose", "Slash", "Duff McKagan", "Steven Adler"],
    ["Run", "DMC", "Jam Master Jay"],]
newlist=[]
def enlisting(list):
number_of_lists = len(list)    # length of the main list
n=0
for sublist in (list [:]):          # it shall print the main list number of times equal to sublists 
    if n != number_of_lists :
        n +=1 
        for a in (sublist [:]) :
            newlist.append(a)
print(", ".join(newlist))            
enlisting(musical_groups)
```

Steven Parker · Accepted Answer

I managed to find the Multidimensional Musical Groups (https://teamtreehouse.com/library/introducing-lists/build-an-application/multidimensional-musical-groups) challenge in the Introducing Lists (https://teamtreehouse.com/library/introducing-lists) course.  After testing your code, I discovered that the function does not have access to the global variable "newlist".
You can fix that either by moving the variable declaration inside the function (recommended), or by giving the function access to it by declaring global newlist at the start of the function.  It's also not necessary to have a function at all, the challenge can be met with just inline code (which would also resolve the access issue).
And FYI, while it doesn't keep it from working, the code is unnecessarily complex.   You don't need the slices or extra parentheses in the loops.   For example: "for a in (sublist [:]) :" can just be "for a in sublist:".

Bienvenido a la Comunidad de Treehouse

¿Buscas aprender algo nuevo?

Karrar Al Arbo

Karrar Al Arbo

listas - sublistas

Steven Parker

Steven Parker

1 Respuesta

Steven Parker

Steven Parker

Karrar Al Arbo

Karrar Al Arbo